Implement min/max advertisement interval#60
Merged
spacecheese merged 2 commits intospacecheese:developfrom Apr 7, 2026
Merged
Conversation
Made-with: Cursor
Owner
|
Looks good to me, thanks for the PR. I have some test updates in the works I will bring in before I release a new alpha. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows specifying advertisement intervals.
This has been written by AI (Cursor), but verified by me. It's tested and working. See this excerpt from
btmon, showing that the min & max interval are correclty set to 20ms & 50ms as specified in my application code using this library.I chose to base this on top of develop instead of main since the structure of Advertisment was changed in a way where the implementation was easier. Hopefully that's ok? Alternatively this could be merged into main after develop is?